This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(Angular): Infinite $digest Loop occur when using deep $watch on an o... #8715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n object that contains an "Invalid Date" Add better check for invalid dates in method equals. fixes angular#8650
|
This looks good to me, but I wonder if we could make the NaN testing in equals() a bit better.. Probably good to merge this for now though |
|
I don't think #8718 is any better, as mentioned in the PR --- will have to do better than that to clean up that function |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...bject that contains an "Invalid Date"
Add better check for invalid dates in method equals.
fixes #8650